[Core] Add distribute variable method to variable utils #7146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
Co-authored-by: Rubén Zorrilla <rubenzorrillamartinez@hotmail.com>
…ttps://github.com/KratosMultiphysics/Kratos into core/variable_utils/add_distribute_variable_method
rubenzorrilla
approved these changes
Jun 28, 2020
sunethwarna
deleted the
core/variable_utils/add_distribute_variable_method
branch
|
guys please don't open PRs on Sat and merge on Sunday, esp for additions to the core note to self: add to code of conduct |
philbucher
reviewed
Jun 28, 2020
Comment on lines
+516
to
+519
| const std::function<double(const Node<3>&)>& r_weight_method = | ||
| (IsInverseWeightProvided) ? | ||
| static_cast<std::function<double(const Node<3>&)>>([rWeightVariable](const Node<3>& rNode) -> double {return 1.0 / rNode.GetValue(rWeightVariable);}) : | ||
| static_cast<std::function<double(const Node<3>&)>>([rWeightVariable](const Node<3>& rNode) -> double {return rNode.GetValue(rWeightVariable);}); |
There was a problem hiding this comment.
- I think using std function has some overhead, use with caution in performance critical parts
- There is no check for
rNode.GetValue(rWeightVariable). If it is 0 then it will crash. This happens if this var was not allocate
There was a problem hiding this comment.
- I added the check in full debug only. Should I change it to release as well? I didnt do it considering the performance impact. ()
Kratos/kratos/utilities/variable_utils.cpp
Lines 532 to 535 in 323771c
- As for the zeros, I can add a check in full debug again. Would it be sufficient?
|
@philbucher sorry, I wasn't thinking like that. I will keep this in mind in future :/ |
sunethwarna
restored the
core/variable_utils/add_distribute_variable_method
branch
sunethwarna
deleted the
core/variable_utils/add_distribute_variable_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to variable_utils to distribute variables(double, and array_3d) in elemental or condition data value container to nodal non-historical data value container with a specified weight. Tests are also added.