[Core] Adding kratos_api to geometry_utils #7113
Conversation
sunethwarna
added
the
FastPR
| @@ -116,7 +116,7 @@ void GeometryUtils::EvaluateHistoricalVariableGradientAtGaussPoint( | |||
|
|
|||
| // template instantiations | |||
|
|
|||
| template void GeometryUtils::EvaluateHistoricalVariableValueAtGaussPoint<array_1d<double, 3>>( | |||
There was a problem hiding this comment.
I am confused as to why you add this in the cpp
@roigcarlo you know the win stuff better, can you take a look please?
There was a problem hiding this comment.
It is to have noalias for non primitive types, and not to have noalias for doubles
There was a problem hiding this comment.
I get that but I never saw KRATOS_API in a source file
There was a problem hiding this comment.
I followed what is done in the earlier PR for stat app.. No idea why I did it :|, @roigcarlo could you maybe clarify where we need to put KRATOS_API to make it compile in windows?
There was a problem hiding this comment.
Explicit instabtiations without especialization.
To be completely honest still not sure if it is needed or its enough with the instantiation. If it passes thr ci withoit you can remove it.
There was a problem hiding this comment.
Could you may be add it to wiki :), how one should add KRATOS_API?. There are lots of developers who only has linux compilations in their workstations. So we rely on CI to capture windows compilation errors and it takes time also. :/
In this case, it was not even captured in original PR because, this was not used until now in #7039.
There was a problem hiding this comment.
I added a page here @roigcarlo @philbucher according to my experiences with trial and error. Could you please have a look?
https://github.com/KratosMultiphysics/Kratos/wiki/KRATOS_API-for-Windows-Compilation
There was a problem hiding this comment.
to me looks ok but I am not a Win expert 🤸♂️
|
I think this PR now only have least amount of KRATOS_API usage. |
|
thanks @philbucher and @roigcarlo :) |
sunethwarna
deleted the
core/geometry_utils/expose_evaluate_at_gauss_point_to_windows
branch
I forgot to add kratos_api to few methods introduced recently.