-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visited flag #7110
Fix visited flag #7110
Conversation
c32281a
to
c46f09b
Compare
Also we should improve the tests for this, its alarming that this were not catch :S |
Eieiei this should solve the problem right? |
Actually it was worst than before :P. |
For me it works, seems to solve the problem in #7109. Perhaps @AndreasWinterstein can also say if this solves it for him as well, but I am quite confident it should. |
@roigcarlo should we port this also to the release? |
Well release is done, we should add it to the next one (probably 8.0.1) with a couple of other important bugfixes. I can make a release once this is merged. |
ok makes sense |
@roigcarlo can you add a small test? I.e. it should give the same results in OpenMP and MPI, this way I think we are on the safe side in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Will add the test next week |
There is a OMP test in #7062 |
That should be an OR