Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visited flag #7110

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fix visited flag #7110

merged 1 commit into from
Jun 19, 2020

Conversation

roigcarlo
Copy link
Member

That should be an OR

@roigcarlo roigcarlo force-pushed the mpi/fix-visited-flag branch from c32281a to c46f09b Compare June 18, 2020 17:44
@roigcarlo
Copy link
Member Author

Also we should improve the tests for this, its alarming that this were not catch :S

@philbucher
Copy link
Member

Eieiei this should solve the problem right?
Basically you were again accumulating multiple times the values like before right?

@roigcarlo
Copy link
Member Author

Actually it was worst than before :P.
Was a corner case before, with the and and or swaped it turned it quite more frequent

@mpentek
Copy link
Member

mpentek commented Jun 19, 2020

For me it works, seems to solve the problem in #7109. Perhaps @AndreasWinterstein can also say if this solves it for him as well, but I am quite confident it should.

@philbucher
Copy link
Member

@roigcarlo should we port this also to the release?

@roigcarlo
Copy link
Member Author

Well release is done, we should add it to the next one (probably 8.0.1) with a couple of other important bugfixes. I can make a release once this is merged.

@philbucher
Copy link
Member

Well release is done, we should add it to the next one (probably 8.0.1) with a couple of other important bugfixes. I can make a release once this is merged.

ok makes sense

@philbucher
Copy link
Member

@roigcarlo can you add a small test? I.e. it should give the same results in OpenMP and MPI, this way I think we are on the safe side in the future

Copy link
Member

@mpentek mpentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roigcarlo roigcarlo merged commit d85034d into master Jun 19, 2020
@roigcarlo roigcarlo deleted the mpi/fix-visited-flag branch June 19, 2020 13:54
@roigcarlo
Copy link
Member Author

Will add the test next week

@loumalouomega
Copy link
Member

Will add the test next week

There is a OMP test in #7062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants