Added a helper function for converting angles from degrees to radians

KratosMultiphysics · May 26, 2023 · 2a69cd4 · 2a69cd4
1 parent dc3b086
commit 2a69cd4
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/applications/GeoMechanicsApplication/custom_elements/steady_state_Pw_piping_element.cpp b/applications/GeoMechanicsApplication/custom_elements/steady_state_Pw_piping_element.cpp
@@ -13,7 +13,10 @@
 // Application includes
 #include "custom_elements/steady_state_Pw_piping_element.hpp"
 #include "custom_utilities/element_utilities.hpp"
+#include "utilities/math_utils.h"
 #include <cmath>
+
+
 namespace Kratos
 {
 
@@ -328,7 +331,7 @@ double SteadyStatePwPipingElement<TDim,TNumNodes>:: CalculateEquilibriumPipeHeig
         return 1e10;
     }
 
-    return modelFactor * M_PI / 3.0 * particle_d * (SolidDensity / FluidDensity - 1) * eta  * sin((theta  + pipeSlope) * M_PI / 180.0) / cos(theta * M_PI / 180.0) / dhdx;
+    return modelFactor * M_PI / 3.0 * particle_d * (SolidDensity / FluidDensity - 1) * eta  * sin(MathUtils<>::DegreesToRadians(theta  + pipeSlope)) / cos(MathUtils<>::DegreesToRadians(theta)) / dhdx;
 
 }
 

diff --git a/kratos/tests/cpp_tests/utilities/test_math_utils.cpp b/kratos/tests/cpp_tests/utilities/test_math_utils.cpp
@@ -892,5 +892,16 @@ namespace Kratos
             KRATOS_CHECK_MATRIX_NEAR(exp_A, A, 1.0e-8);
         }
 
+        /** Checks whether the angle conversion from degrees to radians is performed correctly
+         */
+        KRATOS_TEST_CASE_IN_SUITE(MathUtilsDegreesToRadians, KratosCoreFastSuite)
+        {
+            const double abs_tolerance = 1e-9;
+            KRATOS_CHECK_NEAR(          0.0, MathUtils<>::DegreesToRadians(   0.0), abs_tolerance);
+            KRATOS_CHECK_NEAR(Globals::Pi/2, MathUtils<>::DegreesToRadians(  90.0), abs_tolerance);
+            KRATOS_CHECK_NEAR( -Globals::Pi, MathUtils<>::DegreesToRadians(-180.0), abs_tolerance);
+            KRATOS_CHECK_NEAR(4*Globals::Pi, MathUtils<>::DegreesToRadians( 720.0), abs_tolerance);
+        }
+
     } // namespace Testing
 }  // namespace Kratos.
diff --git a/kratos/utilities/math_utils.h b/kratos/utilities/math_utils.h
@@ -25,6 +25,7 @@
 // Project includes
 #include "input_output/logger.h"
 #include "includes/ublas_interface.h"
+#include "includes/global_variables.h"
 
 namespace Kratos
 {
@@ -1819,6 +1820,12 @@ class KRATOS_API(KRATOS_CORE) MathUtils
         }
     }
 
+
+    static double DegreesToRadians(double AngleInDegrees)
+    {
+        return (AngleInDegrees * Globals::Pi) / 180.0;
+    }
+
     ///@}
 
 private: