Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config rework #111

Merged
merged 6 commits into from
Sep 4, 2024
Merged

fix: config rework #111

merged 6 commits into from
Sep 4, 2024

Conversation

Krande
Copy link
Owner

@Krande Krande commented Sep 4, 2024

use a new datastructure for handling configuration of adapy using either a config file or using environment variables

Copy link

codspeed-hq bot commented Sep 4, 2024

CodSpeed Performance Report

Merging #111 will not alter performance

Comparing fix/config-rework (b123f46) with main (f5ad492)

Summary

✅ 5 untouched benchmarks

Copy link

github-actions bot commented Sep 4, 2024

👋 Hi there! I have checked your PR and found no issues. Thanks for your contribution!

PR Review:

I found no pr-related issues.

  • ✅ PR title is ok
  • ✅ Release label is ok
  • ✅ SOURCE_KEY is set as a secret
  • ✅ Calculated next version: "0.2.18"

Python Review:

I found no python-related issues.

Python Linting results:

  • ✅ Isort
  • ✅ Black
  • ✅ Ruff

Python Packaging results:

  • ✅ I found the PYPI_API_TOKEN secret.
Packaging Type Package Name Version
pyproject.toml ada-py 0.2.17
pypi ada-py 0.2.17

@Krande Krande merged commit 62980ac into main Sep 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant