Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ifc rel mat efficiency #109

Merged
merged 47 commits into from
Sep 3, 2024
Merged

fix: ifc rel mat efficiency #109

merged 47 commits into from
Sep 3, 2024

Conversation

Krande
Copy link
Owner

@Krande Krande commented Sep 2, 2024

Work on improving IFC writing efficiency and add software performance benchmarking for relevant IFC writes

Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #109 will improve performances by ×2.6

Comparing fix/ifc-rel-mat-efficiency (f18b365) with main (91b7ec9)

Summary

⚡ 4 improvements
✅ 1 untouched benchmarks

Benchmarks breakdown

Benchmark main fix/ifc-rel-mat-efficiency Change
test_build_big_ifc_beams 6.9 s 5.9 s +16.52%
test_build_big_ifc_box 1,673.9 ms 707.2 ms ×2.4
test_build_big_ifc_plates 7.1 s 6.1 s +16.11%
test_build_big_ifc_sphere 1,587.6 ms 620.3 ms ×2.6

Copy link

github-actions bot commented Sep 3, 2024

👋 Hi there! I have checked your PR and found no issues. Thanks for your contribution!

PR Review:

I found no pr-related issues.

  • ✅ PR title is ok
  • ✅ Release label is ok
  • ✅ SOURCE_KEY is set as a secret
  • ✅ Calculated next version: "0.2.17"

Python Review:

I found no python-related issues.

Python Linting results:

  • ✅ Isort
  • ✅ Black
  • ✅ Ruff

Python Packaging results:

  • ✅ I found the PYPI_API_TOKEN secret.
Packaging Type Package Name Version
pyproject.toml ada-py 0.2.16
pypi ada-py 0.2.16

@Krande Krande merged commit 3231486 into main Sep 3, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant