Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading of gdk_pixbuf library on Ubuntu (fix #63) #69

Merged
merged 1 commit into from
Aug 3, 2015
Merged

Fix loading of gdk_pixbuf library on Ubuntu (fix #63) #69

merged 1 commit into from
Aug 3, 2015

Conversation

gutard
Copy link
Contributor

@gutard gutard commented Aug 3, 2015

This PR fixes issue #63 on Ubuntu by adding a suffix .0 to the library name to search.

Maybe a more elegant solution would be to use ctypes.util.find_library('gdk_pixbuf'). I did not test on other distros or platforms but it works on Ubuntu.

@SimonSapin
Copy link
Member

Sigh

Thanks for looking into it! I wonder if using something like pkg-config is the answer here, rather than continuing to pile on more name variations.

SimonSapin added a commit that referenced this pull request Aug 3, 2015
@SimonSapin
Merge pull request #69 from makinacorpus/master
a0c6f3c 
Fix loading of gdk_pixbuf library on Ubuntu (fix #63)
@SimonSapin SimonSapin merged commit a0c6f3c into Kozea:master Aug 3, 2015
@SimonSapin
Copy link
Member

Oh, you already mentioned find_library :) Yes, it’s worth looking into if someone want to try it on various platforms.

On my system (Archlinux x86_64) ctypes.util.find_library('gdk_pixbuf') doesn’t work but ctypes.util.find_library('gdk_pixbuf-2.0') does.

@SimonSapin
Copy link
Member

Ok, I just released v0.7.2 with this change: 729a5b8. Does it work for you?

@liZe liZe mentioned this pull request Aug 10, 2019
Closed
liZe added a commit that referenced this pull request Aug 10, 2019
@liZe
Don't use find_library anymore to find cairo
8144f6e 
As the simpler code used in WeasyPrint is widely used, we can assume that it
works. If someone complains, adding more library names in various dlopen calls
is probably the way to go.

This commit somehow reverts #69. Related to #119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gutard @SimonSapin