Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation #1672

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Improve documentation #1672

merged 2 commits into from
Nov 28, 2019

Conversation

qwwdfsad
Copy link
Collaborator 

* Clarifications of CoroutineExceptionHandler execution
* Clarifications of MainCoroutineDispatcher.immediate
* Outdated documentation (pointed out by Google AndoidX team) for isDispatchNeeded is rewritten

Fixes #1650
Fixes #1651
Fixes #1634

@qwwdfsad
Improve documentation
5af4f91 
    * Clarifications of CoroutineExceptionHandler execution
    * Clarifications of MainCoroutineDispatcher.immediate
    * Outdated documentation (pointed out by Google AndoidX team) for isDispatchNeeded is rewritten
    *

Fixes #1650
Fixes #1651
Fixes #1634
@qwwdfsad qwwdfsad requested a review from elizarov November 25, 2019 15:59
elizarov
elizarov suggested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, but I'm worried that we don't document the rationale behind the default dipsatcher's implementation anymore.

kotlinx-coroutines-core/common/src/CoroutineDispatcher.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-core/common/src/CoroutineDispatcher.kt Outdated Show resolved Hide resolved
kotlinx-coroutines-core/common/src/CoroutineDispatcher.kt Outdated Show resolved Hide resolved
@qwwdfsad qwwdfsad requested a review from elizarov November 26, 2019 11:08
elizarov
elizarov approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great.

@qwwdfsad qwwdfsad merged commit 391042f into develop Nov 28, 2019
@qwwdfsad qwwdfsad deleted the docs-fixes branch November 28, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov