Implemented warn on verification error #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
force-pushed
the
warn-verify
branch
2 times, most recently
from
57a1ddb to
930225b
Compare
sandwwraith
reviewed
Mar 26, 2024
| @@ -29,11 +29,14 @@ koverReport { | |||
|
|
|||
| // verification rules for verification task | |||
| verify { | |||
| // fail on verification error | |||
| warnOnFailure = false | |||
There was a problem hiding this comment.
IMO, 'warnOnFailure' doesn't indicate that failure won't happen. I think something like warningInsteadOfFailure conveys meaning better.
|
|
||
| run("koverVerify") { | ||
| taskOutput(":koverVerify") { | ||
| match { |
There was a problem hiding this comment.
Should we also check that build finished successfully?
...radle-plugin/src/main/kotlin/kotlinx/kover/gradle/plugin/appliers/tasks/VariantReportsSet.kt
Show resolved
Hide resolved
sandwwraith
reviewed
Mar 26, 2024
|
Sorry, pushed |
sandwwraith
approved these changes
Mar 26, 2024
shanshin
force-pushed
the
features-instead-intellij
branch
from
6e49c2e to
198a96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added property to suppress task execution failure if there has been a violation of the verification rules
Resolves #339