applicationVariants/libraryVariants are eagerly evaluated and result in missed test data #362

ZacSweers · 2023-05-04T19:32:16Z

Describe the bug
This code eagerly evaluates applicationVariants/libraryVariants in Android projects, and the result is that they have empty variants if the plugin is applied before the android variants are set up and the kover report task will be skipped due to no inputs.

kotlinx-kover/src/main/kotlin/kotlinx/kover/gradle/plugin/locators/Android.kt

Lines 28 to 32 in 9c36932

    
           val variants = if ("applicationVariants" in androidExtension) { 
        
               androidExtension.propertyBeans("applicationVariants") 
        
           } else { 
        
               androidExtension.propertyBeans("libraryVariants") 
        
           }

Errors
If present, stacktraces or files from build/kover/errors directory

Expected behavior
This API is old and the wrong API to use. Instead, the new androidComponents.onVariants API should be used, as this is a push system that will callback with each variant. This API is present in AGP 7.0 and later.

Reproducer
Easy to reproduce in a project that applies the kover plugin before configuring android variants.

Reports
If applicable, report files or screenshots.

Environment

Kover Gradle Plugin version: 0.7.0-Beta
Gradle version: 8.0.2/8.1.1
Kotlin project type: Kotlin/Android
Coverage Engine version (if customized in build script): N/A
Other context important for this bug: [e.g. OS version]

The text was updated successfully, but these errors were encountered:

ZacSweers · 2023-05-04T19:33:27Z

I should mention I've verified the racy behavior by delaying applying the kover plugin behind an afterEvaluate block

shanshin · 2023-05-04T20:24:48Z

Great, thanks!

We will create improved locator for AGP >= 7.0

Kotlin/kotlinx-kover#362

Kotlin/kotlinx-kover#362

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.slack.gradle.root](https://togithub.com/slackhq/slack-gradle-plugin) | `0.9.0` -> `0.9.3` | [![age](https://badges.renovateapi.com/packages/maven/com.slack.gradle.root/0.9.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.slack.gradle.root/0.9.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.slack.gradle.root/0.9.3/compatibility-slim/0.9.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.slack.gradle.root/0.9.3/confidence-slim/0.9.0)](https://docs.renovatebot.com/merge-confidence/) | | [com.slack.gradle.base](https://togithub.com/slackhq/slack-gradle-plugin) | `0.9.0` -> `0.9.3` | [![age](https://badges.renovateapi.com/packages/maven/com.slack.gradle.base/0.9.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.slack.gradle.base/0.9.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.slack.gradle.base/0.9.3/compatibility-slim/0.9.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.slack.gradle.base/0.9.3/confidence-slim/0.9.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>slackhq/slack-gradle-plugin</summary> ### [`v0.9.3`](https://togithub.com/slackhq/slack-gradle-plugin/blob/HEAD/CHANGELOG.md#093) [Compare Source](https://togithub.com/slackhq/slack-gradle-plugin/compare/0.9.2...0.9.3) *2023-05-05* - Add `jdk.compiler/com.sun.tools.javac.model` to Bootstrap Gradle JVM args and exec prefixes for binaries for GJF 17. ### [`v0.9.2`](https://togithub.com/slackhq/slack-gradle-plugin/blob/HEAD/CHANGELOG.md#092) [Compare Source](https://togithub.com/slackhq/slack-gradle-plugin/compare/0.9.1...0.9.2) *2023-05-05* - Fix accidental noisy JVM vendor log. ### [`v0.9.1`](https://togithub.com/slackhq/slack-gradle-plugin/blob/HEAD/CHANGELOG.md#091) [Compare Source](https://togithub.com/slackhq/slack-gradle-plugin/compare/0.9.0...0.9.1) *2023-05-04* Happy May the Fourth! - Add new `sgp.config.jvmVendor` property to control the JVM vendor used in Kotlin and Java toolchains. This value is used to match a known vendor spec, such as `AZUL`. - Apply the kover plugin in an `afterEvaluate` block to avoid [https://github.com/Kotlin/kotlinx-kover/issues/362](https://togithub.com/Kotlin/kotlinx-kover/issues/362). - Update jgrapht to 1.5.2. - Update oshi to 6.4.2. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ZacSweers/CatchUp).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

There's currently a bug in 0.7.0 with Android projects where it reports it's skipping generation as not tests found:Kotlin/kotlinx-kover#362 This is a temporary workaround.

Now the search for build variants takes place in the `afterEvaluate` action, which is added when `finalizeDsl` is called - thus the Kover code is guaranteed to be executed after creating variants. Additional changes: * added DSL accessors for Kover Default report tasks * added descriptions for Kover report tasks * added functions for getting Kover Android report task names Fixes #362 Fixes #394 Fixes #400

shanshin · 2023-06-27T15:45:22Z

Fixed in 0.7.2.

#### Description: - I am working on updating our _kover_ version to `0.8.1` in the `slack-android-ng` repo and this workaround is no longer needed and actually fails the command if it's present. - So removing this and will include this in a future release once the PR is merged to switch over in `slack-android-ng` - The original issue is now fixed and merged: Kotlin/kotlinx-kover#362

ZacSweers added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels May 4, 2023

ZacSweers assigned shanshin May 4, 2023

shanshin added S: in progress Status: implementing or design in process and removed S: untriaged Status: issue reported but unprocessed labels May 4, 2023

ZacSweers added a commit to slackhq/foundry that referenced this issue May 4, 2023

Work around kover bug

eb2c710

Kotlin/kotlinx-kover#362

ZacSweers mentioned this issue May 4, 2023

Work around kover bug slackhq/foundry#349

Merged

shanshin mentioned this issue May 10, 2023

Task 'koverXmlReport' will be skipped because no tests were executed in Android project on 0.7.0 #364

Closed

sabufung30 mentioned this issue May 27, 2023

Android 'debug' variant not found in KMM + Android project #388

Closed

This was referenced May 31, 2023

Tests are not executed #391

Closed

Multiple issues when migrating from custom plugin to kotlinx-kover #398

Closed

This was referenced Jun 5, 2023

./gradlew koverReport does not work anymore after migrating to 0.7 #402

Closed

Example of koverVerify usage with "Minimal line coverage rate in percents" rule in 0.7.1 #404

Closed

outadoc mentioned this issue Jun 9, 2023

Kover 0.7.1 failure at configuration time - gradleWrapper.getProperty(name) must not be null #405

Closed

shanshin mentioned this issue Jun 9, 2023

Removed the dependency on the order of applying of the plugin #406

Merged

shanshin closed this as completed in #406 Jun 16, 2023

shanshin reopened this Jun 16, 2023

shanshin added S: ready for release Status: merged in the main branch and removed S: in progress Status: implementing or design in process labels Jun 16, 2023

shanshin closed this as completed in 21aa8b3 Jun 27, 2023

jstewart5000 mentioned this issue Jul 2, 2024

Remove Kover Workaround for 0.7.1 slackhq/foundry#890

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

applicationVariants/libraryVariants are eagerly evaluated and result in missed test data #362

applicationVariants/libraryVariants are eagerly evaluated and result in missed test data #362

ZacSweers commented May 4, 2023

ZacSweers commented May 4, 2023

shanshin commented May 4, 2023

shanshin commented Jun 27, 2023

applicationVariants/libraryVariants are eagerly evaluated and result in missed test data #362

applicationVariants/libraryVariants are eagerly evaluated and result in missed test data #362

Comments

ZacSweers commented May 4, 2023

ZacSweers commented May 4, 2023

shanshin commented May 4, 2023

shanshin commented Jun 27, 2023