Optimize performance of extension functions defined on Source when called on a Buffer #342
Open
2 of 5 tasks
Labels
Comments
This was referenced Jun 12, 2024
qwwdfsad
added a commit
that referenced
this issue
Aug 21, 2024
* Request Long.MAX_VALUE from the source at once (note: no need for a loop as we are unable to build the string of such size anyway) * Get rid of redundant checks in commonReadUtf8 Ticks one of the boxes in #342
qwwdfsad
added a commit
that referenced
this issue
Aug 23, 2024
* Request Long.MAX_VALUE from the source at once (note: no need for a loop as we are unable to build the string of such size anyway) * Get rid of redundant checks in commonReadUtf8 Ticks one of the boxes in #342
qwwdfsad
added a commit
that referenced
this issue
Aug 23, 2024
* Request Long.MAX_VALUE from the source at once (note: no need for a loop as we are unable to build the string of such size anyway) * Get rid of redundant checks in commonReadUtf8 Ticks one of the boxes in #342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some extension functions defined on a
Source(likereadStringorreadCodePointValue) prefetch data into the source's buffer and then delegate further processing to buffer-specific functions. When invoked on aBuffer, these functions still do all these unnecessary prefetching actions. Instead, such calls should be delegated to a Buffer directly.Potentially affected functions are:
Source.readCodePointValue()Source.readString()Source.readHexadecimalUnsignedLong()Source.readDecimalLong()Source.indexOfThe text was updated successfully, but these errors were encountered: