Correctly enqueue data in moveToTail

Kotlin · Jun 4, 2024 · c923ad2 · c923ad2
1 parent e9cc737
commit c923ad2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/core/common/src/unsafe/UnsafeBufferOperations.kt b/core/common/src/unsafe/UnsafeBufferOperations.kt
@@ -43,7 +43,7 @@ public object UnsafeBufferOperations {
         val tail = buffer.tail
         if (tail == null) {
             buffer.head = segment
-            buffer.tail = tail
+            buffer.tail = segment
         } else {
             buffer.tail = tail.push(segment)
         }

diff --git a/core/common/test/unsafe/UnsafeBufferOperationsMoveTest.kt b/core/common/test/unsafe/UnsafeBufferOperationsMoveTest.kt
@@ -76,4 +76,16 @@ class UnsafeBufferOperationsMoveTest {
             UnsafeBufferOperations.moveToTail(Buffer(), ByteArray(10), 11, 12)
         }
     }
+
+    @Test
+    fun moveMultipleSegments() {
+        val buffer = Buffer()
+        val segmentsCount = 10
+        for (i in 0 ..< segmentsCount) {
+            UnsafeBufferOperations.moveToTail(buffer, byteArrayOf(i.toByte()))
+        }
+        assertEquals(10, buffer.size)
+        assertEquals(listOf(1, 1, 1, 1, 1, 1, 1, 1, 1, 1), segmentSizes(buffer))
+        assertContentEquals(ByteArray(segmentsCount) { it.toByte() }, buffer.readByteArray())
+    }
 }