Add comm-message handlers and support for debugPort config retrieval #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolay-egorov
force-pushed
the
debug-port-message-handle
branch
from
881d31c to
68d19f6
Compare
|
Adjusted api to be compatible with comms callbacks, added interface for some standard handlers for kernel-provided comms |
nikolay-egorov
force-pushed
the
debug-port-message-handle
branch
from
68d19f6 to
a356529
Compare
ileasile
suggested changes
Jun 26, 2022
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
| override val targetId: String | ||
| get() = OPEN_DEBUG_PORT_TARGET | ||
|
|
||
| override val onReceiveAction: CommMessageProcessCallback |
There was a problem hiding this comment.
Maybe val => fun and rename?
| @@ -205,6 +208,10 @@ class ReplForJupyterImpl( | |||
|
|
|||
| private val resourcesProcessor = LibraryResourcesProcessorImpl() | |||
|
|
|||
| init { | |||
| registerKnownCommsHandlersOnStartUp(this) | |||
There was a problem hiding this comment.
I'd like to refactor repl class in a way it would be fully configurable via factory. Please make it possible to configure (switch off/on, add specific handlers) registration of these comms via factory
nikolay-egorov
force-pushed
the
debug-port-message-handle
branch
2 times, most recently
from
db0dc9c to
3295b26
Compare
ileasile
reviewed
Aug 30, 2022
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/repl/creating/BaseReplFactory.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/jetbrains/kotlinx/jupyter/messaging/defaultCommHandlers.kt
Outdated
Show resolved
Hide resolved
nikolay-egorov
force-pushed
the
debug-port-message-handle
branch
from
3295b26 to
016bf95
Compare
ileasile
suggested changes
Aug 31, 2022
src/main/kotlin/org/jetbrains/kotlinx/jupyter/repl/creating/ReplFactory.kt
Outdated
Show resolved
Hide resolved
…ugPortComm messages in kernel
nikolay-egorov
force-pushed
the
debug-port-message-handle
branch
from
016bf95 to
8fa1bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.