Library configuration improvements #34

nikitinas · 2019-12-17T08:10:51Z

Split library descriptors into separate jsons
Load local library descriptors from "/.jupyter_kotlin/libraries" directory
Download library descriptors from master branch of "https://github.com/Kotlin/kotlin-jupyter" repository
Cache downloaded descriptors in "/.jupyter_kotlin/cache/libraries" directory
Make descriptors loading async
Check library descriptor format version and suggest updating kernel if format was changed

Fixes #31

ileasile

There are few minor comments, may you please answer them / fix?

src/main/kotlin/org/jetbrains/kotlin/jupyter/repl.kt

src/main/kotlin/org/jetbrains/kotlin/jupyter/config.kt

src/main/kotlin/org/jetbrains/kotlin/jupyter/repl.kt

ileasile

One more note

src/main/kotlin/org/jetbrains/kotlin/jupyter/config.kt

…t them as unordered dictionary instead of an ordered list. Unnamed argument is allowed only if library has single property declaration

ileasile · 2019-12-23T08:42:16Z

src/main/kotlin/org/jetbrains/kotlin/jupyter/util.kt

+fun <T> Deferred<T>.awaitBlocking(): T = if (isCompleted) getCompleted() else runBlocking { await() }
+
+fun String.parseIniConfig() =
+        split("\n").map { it.split('=') }.filter { it.count() == 2 }.map { it[0] to it[1] }.toMap()


Why isn't some INI parser used? In this implementation comments (;) are not handled properly. I understand that .properties has only one line, and it may be left as is this time.

nikitinas requested a review from ileasile December 17, 2019 08:10

ileasile reviewed Dec 18, 2019

View reviewed changes

nikitinas force-pushed the remote_config branch from 013adb5 to 08b9a60 Compare December 19, 2019 13:40

nikitinas added 5 commits December 19, 2019 16:43

Split libraries into separate jsons

9cad96e

Add local cache for downloaded library descriptors

968b970

Download library descriptors asynchronously

f1ddadc

Add .properties file with current library descriptor format version

d547ad8

Replace 'http' with 'https' in 'koma.json'

959ece9

nikitinas force-pushed the remote_config branch from 08b9a60 to 959ece9 Compare December 19, 2019 13:44

ileasile reviewed Dec 19, 2019

View reviewed changes

src/main/kotlin/org/jetbrains/kotlin/jupyter/repl.kt Show resolved Hide resolved

ileasile reviewed Dec 19, 2019

View reviewed changes

src/main/kotlin/org/jetbrains/kotlin/jupyter/config.kt Outdated Show resolved Hide resolved

nikitinas added 7 commits December 22, 2019 22:47

Add logging for resolver

4d8c2c3

Rename 'arguments' to 'properties' in library descriptor format, trea…

77a7cfe

…t them as unordered dictionary instead of an ordered list. Unnamed argument is allowed only if library has single property declaration

Clear 'cache/libraries' before writing downloaded files to it

e9121ad

Remove obsolete comment

00293b0

Fix regexp for library descriptor filename

d54a6f7

Move filenameRegex out of cycle

41f0211

Allow '.' in lib name

d5eb6fc

ileasile reviewed Dec 23, 2019

View reviewed changes

nikitinas merged commit 1e416c7 into master Dec 23, 2019

nikitinas deleted the remote_config branch December 23, 2019 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Library configuration improvements #34

Library configuration improvements #34

nikitinas commented Dec 17, 2019 •

edited

Loading

ileasile left a comment

ileasile left a comment

ileasile Dec 23, 2019

Library configuration improvements #34

Library configuration improvements #34

Conversation

nikitinas commented Dec 17, 2019 • edited Loading

ileasile left a comment

Choose a reason for hiding this comment

ileasile left a comment

Choose a reason for hiding this comment

ileasile Dec 23, 2019

Choose a reason for hiding this comment

nikitinas commented Dec 17, 2019 •

edited

Loading