-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create specialized kernels w/ JDK, JVM args, and environment variables #287
Conversation
Hi! Regarding your questions:
|
Autodetection is on hold for now since it's non-trivial, I'd probably do it in another PR. The rest is done, although I did use |
Also, is there a reason |
Making this a draft for now, since I was working on #72 and think it's better done as a |
Went faster than I expected, this fixes #72 too now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @rnett, thank you A LOT!
I have some minor comments. After fixing I'll publish dev packages from your branch to conda and pip so we could test them.
It's ok. I think, 3.4 is the minimal version we should support |
…kernel to reflect that
@rnett Could you please install and try the kernel built from this PR? If everything is fine, I'll merge it |
These was a typo in the readme, but other than that everything worked. Tested environment variables and kernel creation on Windows and WSL. |
Thank you, Ryan! |
Fixes #284.
Fixes #72.
I'd like to note this somewhere in the readme (and that it can be set per-kernel with
env
in the kernelspec), any preference on where?I also thought about a few possible further features:
install_user
, although I can't find where it gets called on initial install).fix-kernelspec-location
-like task to create a kernel for a specific JDK.kotlin-jupyter
specific environment variable that overridesJAVA_HOME
, i.e.KOTLIN_JUPYTER_JAVA
, incase you want jupyter on a different JDK than say gradle (although that's doable via the kernelspec).Thoughts on any of them?