Allow value rendering using renderers processor from API #183
Conversation
| import org.jetbrains.kotlinx.jupyter.api.libraries.ExecutionHost | ||
|
|
||
| interface TypeRenderersProcessor { | ||
|
|
||
| fun renderResult(host: ExecutionHost, field: FieldValue): Any? | ||
|
|
||
| fun renderValue(host: ExecutionHost, value: Any?): Any? |
There was a problem hiding this comment.
It is not clear what this function does. Documentation would be nice.
There was a problem hiding this comment.
I see a problem here. Suppose the value is a container (List<Something>). The type of actual element renderer could not be resolved in the runtime due to type erasure. Won't it require KType?
There was a problem hiding this comment.
Regarding documentation: I've added it.
Regarding renderers: yes, due to type erasure KClass is the most we can get in runtime. It is how all the rendering mechanics works, it only uses KClass for getting type information. We could add Ktype argument here, but it would require breaking the renderers API, and it will actually be useless because it cannot be used for cells results rendering.
ileasile
force-pushed
the
allow_rendering_from_api
branch
from
24121e1 to
343c93d
Compare
Fixes #182
Use it like this: