-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont fail on additional json payload like user_variables #440
Comments
basically have |
Hi! Thanks for pointing this out! Maybe just adding a missing field to the scheme is a better solution? Idea was to keep protocol strict. Will it be possible for you to verify the fix in Google Colab if I prepare a new kernel version? |
Yes, that would be great! happy to try it out as long as I can get some Maven coordinates to test :) |
Add `user_variables` deprecated but still used field to ExecuteResult message. It is still used in Google Colab Perform minor refactorings of messaging subsystem
@maxandersen you can take version 0.12.0-93 to test (or 0.12.0.93 if you're using python dev packages) |
it works! open this gist with google colab and it works. note: %kotlin-statistics does not work in that notebook but seems to be a jitpack/kotlin kernel issue rather than colab afaics. |
note: I've updated the install-kernel script to have the proxy no longer use "ipc" in name, but more that the core kernel will have "-tcp" added in the end. makes the experience on colab consistent with how it works on all the others. |
Thanks for fixing that! |
older kernels like the ones used in google colab sends "user_variables" element.
This makes kotlin kernel fail to run.
Here is log from google colab:
could we make the json parsing more lenient and ignore what it does not know?
The text was updated successfully, but these errors were encountered: