Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every execution request increments execution_count, even if store_history=False #326

Closed
strangepleasures opened this issue Sep 1, 2021 · 1 comment
Labels
bug Installation and functionality issues

Comments

@strangepleasures
Copy link
Contributor

strangepleasures commented Sep 1, 2021

According to Jupyter documentation, execution_count should be incremented only when store_history=True:
"The kernel should have a single, monotonically increasing counter of all execution requests that are made with store_history=True. This counter is used to populate the In[n] and Out[n] prompts. The value of this counter will be returned as the execution_count field of all execute_reply and execute_input messages.".

However, currently even requests with store_history=False increment the counter.

@ileasile
Copy link
Contributor

ileasile commented Sep 1, 2021

Yes, we don't take silent and store_history into consideration for now

@ileasile ileasile added the bug Installation and functionality issues label Sep 1, 2021
strangepleasures added a commit to strangepleasures/kotlin-jupyter that referenced this issue Sep 6, 2021
ileasile pushed a commit to strangepleasures/kotlin-jupyter that referenced this issue Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Installation and functionality issues
Projects
None yet
Development

No branches or pull requests

2 participants