-
Notifications
You must be signed in to change notification settings - Fork 75
From rows to data frame #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
From rows to data frame #1463
Conversation
@koperagen do you think it will cause issues in combination with #1465 ? or should this be good to go? |
No issues, but in Iterable.toDataFrame we'll treat Map as value type and won't unfold it. I think it makes sense as a default So results would be,
=>
|
@koperagen and what about |
Iterable.toDataFrame relies on T to traverse properties. T of listOf(myMap, 1, "") is Any => Nothing changes here |
Okay, in that case we can probably add it safely. Could you update this branch from |
} | ||
|
||
@Test | ||
fun `should convert iterables of maps representing rows to DataFrame with value column`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*columns
I fixed test name, pulled master, ran apiDump. |
Solving issue #1098