Toast 위치 및 layout 수정 #250
Merged
Toast 위치 및 layout 수정 #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k2645
requested changes
Feb 14, 2024
KCS/KCS/Util/SystemImage.swift
Outdated
Comment on lines
17
to
18
| static let toast = UIImage(systemName: "exclamationmark.circle") | ||
| static let exclamationmark = UIImage(systemName: "exclamationmark.circle") |
There was a problem hiding this comment.
같은 system image를 두번 선언했네요. 하나만 남겨두고 나머지는 지워주세요.
Comment on lines
324
to
357
| func showToast(message: String) { | ||
| let toastView = makeToastView(message: message) | ||
|
|
||
| let windows = UIApplication.shared.connectedScenes | ||
| let scene = windows.first { $0.activationState == .foregroundActive } | ||
| if let windowScene = scene as? UIWindowScene, let windowView = windowScene.windows.first { | ||
| windowView.addSubview(toastView) | ||
| NSLayoutConstraint.activate([ | ||
| toastView.centerXAnchor.constraint(equalTo: windowView.safeAreaLayoutGuide.centerXAnchor), | ||
| toastView.bottomAnchor.constraint(equalTo: windowView.safeAreaLayoutGuide.bottomAnchor, constant: -372) | ||
| ]) | ||
| } | ||
|
|
||
| UIView.animate( | ||
| withDuration: 0.4, | ||
| delay: 0, | ||
| options: .curveEaseIn, | ||
| animations: { | ||
| toastView.alpha = 1.0 | ||
| }, | ||
| completion: { _ in | ||
| UIView.animate( | ||
| withDuration: 0.6, | ||
| delay: 2.0, | ||
| options: .curveEaseOut, | ||
| animations: { | ||
| toastView.alpha = 0.0 | ||
| }, completion: { _ in | ||
| toastView.removeFromSuperview() | ||
| } | ||
| ) | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
HomeViewController에 존재하는 함수와 동일한 로직을 가지고있는 함수로 보입니다. 해당 함수는 extension을에 구현을 해두고 사용해도 될 것 같은데 이렇게 구현한 이유가 궁금합니다.
There was a problem hiding this comment.
동일한 로직이지만 SearchViewController에서는 view.addSubview 하는 방식으로 수정했습니다.
extension으로 수정하는 것은 불가능한 구조입니다!
k2645
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️ Issue Number
🚩 Summary
🛠️ Technical Concerns
Toast의 디자인과 위치
AOS에서는 Toast가 기본 제공 라이브러리이다.
그렇기 때문에, 항상 노출되는 위치에서 노출되고 다른 앱과 같은 이미지의 Toast로 제공되어야 사용자에 혼란을 야기하지 않는다.
iOS는 기본으로 제공되는 Toast가 없기 때문에 Toast의 디자인과 위치를 AOS에 맞추는 것으로 합의했다.
present와 Toast
다른 UIViewController가 present되어 있는데 그 뒤의 UIViewController에서 Toast를 불러오면 present되어있는 UIViewController 뒤에 Toast가 나와서 사용자의 눈에 보이지 않는다.
그렇기 때문에 windowScene을 사용하여 UIViewController와 상관없이 Toast를 띄워줬다.
📋 To Do