fix: no quotes for default values in header fields. (Redocly#1059)

Kontent-ai-Learn · Jun 5, 2020 · 929735e · 929735e
1 parent f894a1f
commit 929735e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/components/Fields/FieldDetails.tsx b/src/components/Fields/FieldDetails.tsx
@@ -28,6 +28,7 @@ export class FieldDetails extends React.PureComponent<FieldProps> {
     const { enumSkipQuotes } = this.context;
 
     const { schema, description, example, deprecated } = field;
+    const rawDefault = !!enumSkipQuotes || field.in === 'header'; // having quotes around header field default values is confusing and inappropriate
 
     let exampleField: JSX.Element | null = null;
     if (showExamples && example !== undefined) {
@@ -57,15 +58,15 @@ export class FieldDetails extends React.PureComponent<FieldProps> {
           {/*{schema.title && <TypeTitle> ({schema.title}) </TypeTitle>}*/}
           <ConstraintsView constraints={schema.constraints} />
           {schema.nullable && <NullableLabel> {l('nullable')} </NullableLabel>}
-          {schema.pattern && <PatternLabel>{schema.pattern}</PatternLabel>}
+          {schema.pattern && <PatternLabel> {schema.pattern} </PatternLabel>}
           {schema.isCircular && <RecursiveLabel> {l('recursive')} </RecursiveLabel>}
         </div>
         {deprecated && (
           <div>
             <Badge type="warning"> {l('deprecated')} </Badge>
           </div>
         )}
-        <FieldDetail raw={enumSkipQuotes} label={l('default') + ':'} value={schema.default} />
+        <FieldDetail raw={rawDefault} label={l('default') + ':'} value={schema.default} />
         {!renderDiscriminatorSwitch && <EnumValues type={schema.type} values={schema.enum} />}{' '}
         {exampleField}
         {<Extensions extensions={{ ...field.extensions, ...schema.extensions }} />}