This repository was archived by the owner on Jul 11, 2023. It is now read-only.
fix(least-conn) change cleanup order #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing an address is a 3 step process;
Now getPeer selects an address from the binary heap maintained by the balancer. That heap was updated in step 3, with this change it is updated in step 1 (removing the address). This seems safer. |
locao
approved these changes
Mar 17, 2021
ghost
approved these changes
Mar 17, 2021
remove address from binary heap upon 'disabling' instead of when 'deleting'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove address from binary heap upon 'disabling' instead of when
'deleting'. Seems safer to prevent race conditions. This means that in between disabling and deleting the address can no longer be selected by GetPeer.