Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update routes in Kong when KongIngress object is updated #92

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Aug 15, 2018

When KongIngress object is updated, the properties of affected routes in
Kong were not changed (#91). This was a known issue and was left as a future
TODO in the past.

This change picks up the changes from KongIngress and patches the routes
in Kong as needed.

When KongIngress object is updated, the properties of affected routes in
Kong were not changed (#91). This was a known issue and was left as a future
TODO in the past.

This change picks up the changes from KongIngress and patches the routes
in Kong as needed.
@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #92 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #92     +/-   ##
=========================================
- Coverage   32.03%   31.94%   -0.1%     
=========================================
  Files          33       33             
  Lines        2859     2880     +21     
=========================================
+ Hits          916      920      +4     
- Misses       1830     1847     +17     
  Partials      113      113
Impacted Files Coverage Δ
internal/ingress/controller/kong.go 0% <0%> (ø) ⬆️
cli/ingress-controller/main.go 22.22% <0%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a315c...66d6eb9. Read the comment docs.

Copy link
Contributor

@fffonion fffonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants