feat: drop compatibility with Kong 1.x #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes workarounds in the code to keep supporting Kong 1.x series. The controller is now compatible with Kong 2.x only.
rainest
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
We'll probably need to add something like this back in for some future version, but as-is we don't have much in the way of a robust Kong API version backwards-compatibility system, so while part of my brain says "no, don't strip this out entirely!", the majority of it says "there's nothing we can reasonably leave in--anything we did would just be a stub that'll just make it harder to add a better system in the future".
mflendrich
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes workarounds in the code to keep supporting Kong 1.x
series.
The controller is now compatible with Kong 2.x only.
Fix #701