Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes deprecated annotations.
Special notes for your reviewer:
Tests still use literal
"konghq.com/regex-priority": 3
style test values instead ofAnnotationPrefix + RegexPriorityKey: 3
package constants. We're kinda moving towards the latter in general, though you could make the argument that we want the literal strings so tests complain in the event that we change something: while that works in code using the constants, users won't have changed their annotations in advance if we release such a change, so those literals could serve as a useful canary to make sure that we call out breaking changes if we do change these in the future.Several tests outside the annotations package referenced
annotations.DeprecatedPluginsKey
and now instead referenceannotations.AnnotationPrefix + annotations.PluginsKey
. For consistency, and lack of an obvious reason not to, the annotations package now exports both the modern prefix and all keys, even though not all keys are currently used in non-annotation tests.