Kong cert order v2 #859
Kong cert order v2 #859
Conversation
go.sum
Outdated
| @@ -9,12 +9,10 @@ cloud.google.com/go v0.43.0/go.mod h1:BOSR3VbTLkk6FDC/TcffxP4NF/FFBGA5ku+jvKOP7p | |||
| cloud.google.com/go v0.44.1/go.mod h1:iSa0KzasP4Uvy3f1mN/7PiObzGgflwredwwASm/v6AU= | |||
| cloud.google.com/go v0.44.2/go.mod h1:60680Gw3Yr4ikxnPRS/oxxkBccT6SA1yMk63TGekxKY= | |||
| cloud.google.com/go v0.44.3/go.mod h1:60680Gw3Yr4ikxnPRS/oxxkBccT6SA1yMk63TGekxKY= | |||
| cloud.google.com/go v0.45.1 h1:lRi0CHyU+ytlvylOlFKKq0af6JncuyoRh1J+QJBqQx0= | |||
There was a problem hiding this comment.
Please revert all the changes in this file.
| if kongCert.CreationTimestamp.After(secret.CreationTimestamp.Time) { | ||
| if kongCert.CreationTimestamp.After(secret.CreationTimestamp.Time) || | ||
| (kongCert.CreationTimestamp.Equal(&secret.CreationTimestamp) && | ||
| *kongCert.cert.ID > string(secret.UID)) { |
There was a problem hiding this comment.
Question:
What is the logic behind this comparison?
Is there a reason why you have not opted for !=?
(blocker for merge)
There was a problem hiding this comment.
As shown in the figure above, when the certificate name and create_time of different namespace When time is consistent, there are problems
Because secretsToSNIs is a map, it is unordered
|
Hi 👋 just checking in with everyone here since this PR hasn't been updated for a while, what do we need to move this forward? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Because it needs to be merged into the next branch, re commit to create pr