Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace pkg/errors with %w #765

Merged
merged 1 commit into from
Jul 13, 2020
Merged

refactor: replace pkg/errors with %w #765

merged 1 commit into from
Jul 13, 2020

Conversation

hbagdi
Copy link
Member

@hbagdi hbagdi commented Jul 8, 2020

What this PR does / why we need it:

Removes the use of github.com/pkg/errors package and instead uses error checking additions shipped in Go 1.13.

Special notes for your reviewer:

This is based on top of #748. Review the HEAD of the PR. I'll rebase once 748 is merged in.

@hbagdi hbagdi requested a review from rainest as a code owner July 8, 2020 20:33
@hbagdi hbagdi requested a review from mflendrich July 8, 2020 20:34
rainest
rainest previously approved these changes Jul 8, 2020
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anything we have outstanding, is there a quick grep we can run to try and catch any new errors that still use the old format?

@hbagdi
Copy link
Member Author

hbagdi commented Jul 9, 2020

For anything we have outstanding, is there a quick grep we can run to try and catch any new errors that still use the old format?

There should not be any because the package was removed in go.mod, meaning we are not using the package in our codebase anywhere.

@hbagdi hbagdi merged commit 5dc4a3b into next Jul 13, 2020
@hbagdi hbagdi deleted the refactor/pkg-errors branch July 13, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants