Feat/kong cluster plugins #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use `As()` function. This is same as the new errors.As function introduced in Go 1.13. We are using the library's function because we use it all over the place. We should refactor to remove thie library and use the stdlib functions introduced in Go 1.13 that provide the same functionality.
This helps in a controller logic to detect 404s vs other errors.
KongClusterPlugins allows user to have Plugin configuration at a cluster-level and share the configuration across multiple workspaces. This also helps users who want to have different personas for defining a plugin configuration and using a plugin on a service or ingress as access to KongClusterPlugin can be setup independent of other resources. KongPlugin in the namespace takes precedence over KongClusterPlugin. Global plugins for KongClusterPlugins are also supported. Based on feedback, in future, we will deperecate global-level KongPlugin support and instead only KongClusterPlugins will support the global label. This will solve the problem of a user with access to a single namespace manipulating proxy behavior for services in all namespaces.
|
cc @rainest |
rainest
approved these changes
Jan 28, 2020
|
Hey @hbagdi, any idea when you will be cutting a release with this feature in it? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KongClusterPlugins allows user to have Plugin configuration at a
cluster-level and share the configuration across multiple workspaces.
This also helps users who want to have different personas for defining a
plugin configuration and using a plugin on a service or ingress as
access to KongClusterPlugin can be setup independent of other resources.
KongPlugin in the namespace takes precedence over KongClusterPlugin.
Global plugins for KongClusterPlugins are also supported.
Based on feedback, in future, we will deperecate global-level KongPlugin
support and instead only KongClusterPlugins will support the global
label. This will solve the problem of a user with access to a
single namespace manipulating proxy behavior for services in all namespaces.
Fix #495