perf: sort and check hash to reduce number of sync operations #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing a sync to Kong in DB or in-memory mode, both are expensive operations and should be avoided if there is no change happening. In a k8s cluster, pods, services change quite often and lead to a lot of events to this controller, which lead to frequent unnecessary reloads. This patch deterministically sorts the final configuration and then caches the hash, which is then compared in the next iteration to avoid a sync if possible. This change piggybacks on the previous commit which consolidates the DB and DB-less mode into one data-structure.
hbagdi
force-pushed
the
perf-improvements
branch
from
20008ef
to
32bf076
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.