feat(admission) implement validation for secret-based credentials #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation currently consists of verifying if each and every required field is provided by the user or not. In future, the validation can be made smarter to include an Admin API call to Kong to verify if the creation of such a credential will succeed or not (see TODO in code).
hbagdi
force-pushed
the
feat/admission-controller-credentials
branch
from
c91434b
to
ea157de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation currently consists of verifying if each and every
required field is provided by the user or not.
In future, the validation can be made smarter to include an Admin API
call to Kong to verify if the creation of such a credential will succeed
or not (see TODO in code).