-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keep Gateway's AttachedRoutes
field up to date
#4052
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4052 +/- ##
======================================
Coverage 60.0% 60.1%
======================================
Files 151 151
Lines 16612 16735 +123
======================================
+ Hits 9982 10066 +84
- Misses 5999 6035 +36
- Partials 631 634 +3
☔ View full report in Codecov by Sentry. |
066634f
to
a7bbe0a
Compare
1773e9b
to
97cce40
Compare
9d827d8
to
f29af72
Compare
3bf622a
to
4998b52
Compare
The AttachedRoutes listenerStatus field gets updated and enforced by the GatewayController. Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
4998b52
to
374db32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the linter is happy and @pmalek's comments are resolved, LGTM
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
e310e86
to
55f96c7
Compare
I found that when we create more than 101 Any idea in here? |
Hi, @gjkim42, thanks for reporting this issue! does this behavior happen consistently at 101? What I mean is, can you confirm it does not happen with 100 routes, but it does with 101? Furthermore, do you have logs with throttling from the API server? It shouldn't happen, as the local cache should be used to retrieve Routes and Gateways 🤔 |
I filed the bug and it has been addressed. Please see #4456 (comment) here. |
Cool, thanks! |
What this PR does / why we need it:
We need to update and keep up to date the
Gateway
'sAttachedRoutes
field, with the actual number of routes accepted by it.Which issue this PR fixes:
Fixes #3120
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR