feat(konnect): react to gateway clients updates in NodeAgent #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
added
area/feature
czeslavo
force-pushed
the
reactively-update-konnect-nodes
branch
from
3da343c
to
53f6f1b
Compare
czeslavo
force-pushed
the
reactively-update-konnect-nodes
branch
from
53f6f1b
to
b973d15
Compare
|
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/4418663939
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3727 +/- ##
=======================================
- Coverage 73.8% 73.4% -0.4%
=======================================
Files 133 133
Lines 15824 15843 +19
=======================================
- Hits 11679 11644 -35
- Misses 3395 3436 +41
- Partials 750 763 +13
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
randmonkey
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently
konnect.NodeAgentruns a loop with a fixed nodes updates period. It makes propagating the changes in Gateways configuration take longer than it could. In this PR, we subscribe to the Gateway clients' changes to reactively update nodes in the Konnect when a change in discovered Gateways is detected.Additionally, it moves the
NodeAgent's tests into a separate test package to make them black-box.Which issue this PR fixes:
Part of #3501.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR