feat(gateway-api): matching routes by Listener.AllowedRoutes
#3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
added
the
area/gateway-api
pmalek
changed the title
Listener.AllowedRoutes
pmalek
force-pushed
the
route-matching-checks-supported-kinds
branch
from
50461f0
to
6078573
Compare
pmalek
force-pushed
the
route-matching-checks-supported-kinds
branch
from
6078573
to
3330303
Compare
pmalek
force-pushed
the
route-matching-checks-supported-kinds
branch
from
3330303
to
f66db93
Compare
pmalek
force-pushed
the
route-matching-checks-supported-kinds
branch
from
f66db93
to
281300e
Compare
randmonkey
reviewed
Nov 22, 2022
randmonkey
approved these changes
Nov 22, 2022
|
Adding do not merge label as I'm not sure about the supported kinds from listeners status ad whether those should be taken into account |
|
Seems like it makes sense to take |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements matching listeners by Listener.AllowedRoutes as well as some refactor in
getSupportedGatewayForRouteWhich issue this PR fixes:
Should fix #2408
Special notes for your reviewer:
This PR also adds matching routes against listener's status and most specifically
.SupportedKinds. I'm not sure if that's the right thing to do given the comment in the spec but it surely feels right. For now in such cases we'd add agatewayv1beta1.RouteReasonNotAllowedByListeners.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR