Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3097): propagate translation failures for missing service's referred client-cert #3137

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Nov 7, 2022

What this PR does / why we need it:

It will propagate translation failures for services for which the referred client-cert cannot be fetched.

Which issue this PR fixes:

Part of #3097.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo self-assigned this Nov 7, 2022
@czeslavo czeslavo added area/feature New feature or request area/ingress-controller and removed size/M labels Nov 7, 2022
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 14:10 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 14:11 Inactive
@czeslavo czeslavo marked this pull request as ready for review November 7, 2022 14:12
@czeslavo czeslavo requested a review from a team as a code owner November 7, 2022 14:12
@czeslavo czeslavo changed the title feat(#3091): propagate translation failures for missing service's referred client-cert feat(#3097): propagate translation failures for missing service's referred client-cert Nov 7, 2022
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 14:33 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 14:34 Inactive
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nite but otherwise 👍

internal/dataplane/parser/ingressrules.go Show resolved Hide resolved
@czeslavo czeslavo requested a review from pmalek November 7, 2022 16:15
pmalek
pmalek previously approved these changes Nov 7, 2022
@pmalek pmalek added this to the KIC v2.8.0 milestone Nov 7, 2022
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 16:36 Inactive
@czeslavo czeslavo requested a review from pmalek November 7, 2022 16:36
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 16:59 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 7, 2022 16:59 Inactive
@czeslavo czeslavo merged commit c9b3bb4 into main Nov 7, 2022
@czeslavo czeslavo deleted the feat/missing-client-cert-secret-propagation branch November 7, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants