chore(build) make distroless default Docker target #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the distroless target to the end of the Dockerfile. This makes it the default when Docker builds are run without a target. Although our make targets and release workflow _do_ specify targets, custom CD may not, and this change leads them to produce a better output.
rainest
force-pushed
the
chore/dockerfile-rearrange
branch
from
b6257d9
to
72a8e25
Compare
pmalek
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move the distroless target to the end of the Dockerfile. This makes it the default when Docker buildx builds are run without a target. Although our make targets and release workflow do specify targets, custom CD may not, and this change leads them to produce a better output.
Which issue this PR fixes:
Inspired by #3036
Special notes for your reviewer:
https://gist.github.com/rainest/ae3f00050b66429aca052eeb7057b540#file-docker-txt-L324-L347 is the example buildx build without this change.
The
docker buildinvocation above just builds everything. There's nothing we can really do for vanilla Docker builds; they always build everything unless you provide a target.This is listed as a fix since we never intended for the FIPS target to be the default and don't have hard guarantees around the order of the Dockerfile. I expect it's unlikely that anyone was omitting a target in a custom pipeline with the expectation that it would produce the FIPS image, given that those aren't really officially a thing.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR