Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIC-KGO integration #2917

Merged
merged 9 commits into from
Sep 13, 2022
Merged

KIC-KGO integration #2917

merged 9 commits into from
Sep 13, 2022

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Sep 9, 2022

What this PR does / why we need it:
Fixes #2913

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@mlavacca mlavacca temporarily deployed to Configure ci September 9, 2022 08:32 Inactive
@mlavacca mlavacca changed the title controller-name flag added KIC-KGO integration Sep 9, 2022
@mlavacca mlavacca temporarily deployed to Configure ci September 9, 2022 14:04 Inactive
@mlavacca mlavacca temporarily deployed to Configure ci September 9, 2022 14:23 Inactive
internal/manager/run.go Outdated Show resolved Hide resolved
internal/manager/run.go Outdated Show resolved Hide resolved
test/e2e/features_test.go Outdated Show resolved Hide resolved
@mlavacca mlavacca temporarily deployed to Configure ci September 9, 2022 15:24 Inactive
@mlavacca mlavacca marked this pull request as ready for review September 9, 2022 15:29
@mlavacca mlavacca temporarily deployed to Configure ci September 12, 2022 09:58 Inactive
@mlavacca mlavacca temporarily deployed to Configure ci September 12, 2022 10:18 Inactive
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca temporarily deployed to Configure ci September 12, 2022 11:06 Inactive
@mlavacca mlavacca temporarily deployed to Configure ci September 12, 2022 11:27 Inactive
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're on the right path. We updated the examples too, which is important. I'm worried about testing: are there some extra test cases that might be prudent to add? Have we manually tested this? I would like to hear @rainest's thoughts as well.

CHANGELOG.md Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_controller.go Outdated Show resolved Hide resolved
@mlavacca
Copy link
Member Author

mlavacca commented Sep 12, 2022

Looks like we're on the right path. We updated the examples too, which is important. I'm worried about testing: are there some extra test cases that might be prudent to add? Have we manually tested this? I would like to hear @rainest's thoughts as well.

Which scenario do you feel we are not testing properly? I think we can add a test case in which a managed GatewayClass is used by the Gateway, and we check that it's not eventually reconciled. WDYT?

Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca temporarily deployed to Configure ci September 12, 2022 17:16 Inactive
@shaneutt
Copy link
Contributor

Looks like we're on the right path. We updated the examples too, which is important. I'm worried about testing: are there some extra test cases that might be prudent to add? Have we manually tested this? I would like to hear @rainest's thoughts as well.

Which scenario do you feel we are not testing properly? I think we can add a test case in which a managed GatewayClass is used by the Gateway, and we check that it's not eventually reconciled. WDYT?

Sounds good 👍

@mlavacca mlavacca temporarily deployed to Configure ci September 12, 2022 17:37 Inactive
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally OK, but I have a question: ExtractUnmanagedGatewayClassMode could cause panic when annotations is nil. If we have some mechanism elsewhere to guarantee that gatewayClass.Annotations is always non-nil, could we add some comments somewhere to notice that? If not guaranteed, we should judge whether annotation is nil in that function.

CHANGELOG.md Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_controller.go Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_controller.go Outdated Show resolved Hide resolved
internal/annotations/annotations.go Show resolved Hide resolved
@mlavacca mlavacca temporarily deployed to Configure ci September 13, 2022 08:22 Inactive
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca temporarily deployed to Configure ci September 13, 2022 08:26 Inactive
@mlavacca mlavacca temporarily deployed to Configure ci September 13, 2022 08:49 Inactive
@mlavacca
Copy link
Member Author

waiting for @shaneutt or @rainest to get the final approval as a double check.

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but I would like us to wait until we have @rainest's explicit review before we merge as he's spent more time than I in this area of the code recently.

Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have? I don't remember anything other than 3.x compatibility issues at this point. I touched status handling stuff but that's only after we've decided to interact with a Gateway.

Semantically we probably should have made separate class/unmanaged checks and called them separately in an umbrella process/don't function, but whatever, that's easy to change later. The tests look appropriate and nothing in the code looks that unusual, :shipit:

@rainest rainest merged commit d9df8bf into main Sep 13, 2022
@rainest rainest deleted the gko-integration branch September 13, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KIC's Gateway API able to work under KGO
4 participants