Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promote Gateway feature gate to beta #2781

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Aug 5, 2022

What this PR does / why we need it:

This patch promotes the "Gateway" feature gate to beta and
turns it on by default for future releases.

Due to the fact that some Gateway API resources are still
in an alpha stage, this commit also creates the new feature
gate "GatewayAlpha" to lock alpha stage APIs behind a gate
that's off by default and not mix them with the beta APIs.

Which issue this PR fixes:

Partially resolves #2779

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated

@shaneutt shaneutt added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Aug 5, 2022
@shaneutt shaneutt added this to the Gateway API - Milestone 3 milestone Aug 5, 2022
@shaneutt shaneutt self-assigned this Aug 5, 2022
@shaneutt shaneutt mentioned this pull request Aug 5, 2022
3 tasks
@shaneutt shaneutt force-pushed the shaneutt/gateway-feature-gate-split branch from 03cd00f to 2f916c5 Compare August 5, 2022 14:47
@shaneutt shaneutt force-pushed the shaneutt/gateway-feature-gate-split branch from 2f916c5 to a9a1387 Compare August 5, 2022 16:12
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2022 16:12 Inactive
@shaneutt shaneutt force-pushed the shaneutt/gateway-feature-gate-split branch from a9a1387 to aaa5ff6 Compare August 5, 2022 18:07
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2022 18:07 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2022 18:29 Inactive
@shaneutt shaneutt marked this pull request as ready for review August 5, 2022 18:46
@shaneutt shaneutt requested a review from a team as a code owner August 5, 2022 18:46
pmalek
pmalek previously approved these changes Aug 5, 2022
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

internal/manager/controllerdef.go Show resolved Hide resolved
@shaneutt shaneutt force-pushed the shaneutt/gateway-feature-gate-split branch from aaa5ff6 to 887a7c3 Compare August 5, 2022 18:58
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2022 18:58 Inactive
@shaneutt shaneutt requested a review from pmalek August 5, 2022 18:58
pmalek
pmalek previously approved these changes Aug 5, 2022
@shaneutt shaneutt force-pushed the shaneutt/gateway-feature-gate-split branch from 887a7c3 to 68176e0 Compare August 5, 2022 19:07
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2022 19:07 Inactive
This patch promotes the "Gateway" feature gate to beta and
turns it on by default for future releases.

Due to the fact that some Gateway API resources are still
in an alpha stage, this commit also creates the new feature
gate "GatewayAlpha" to lock alpha stage APIs behind a gate
that's off by default and not mix them with the beta APIs.
@shaneutt shaneutt requested a review from pmalek August 5, 2022 19:10
@shaneutt shaneutt temporarily deployed to Configure ci August 5, 2022 19:31 Inactive
@shaneutt shaneutt merged commit 6fae6cb into main Aug 6, 2022
@shaneutt shaneutt deleted the shaneutt/gateway-feature-gate-split branch August 6, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Gateway API enabled by default
2 participants