Resend config if status reports hash empty #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
feat/watch-config-hash-2
branch
from
05128c7
to
262c5a0
Compare
rainest
force-pushed
the
feat/watch-config-hash-2
branch
from
262c5a0
to
b5a68cb
Compare
|
Initial E2E run ran this PR's test successfully, but failed on another existing test due to it not actually deploying an Ingress. Second run after fixing that: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/2018941298 |
Check Kong's status endpoint and read its config hash during the update loop. If the config hash reported by Kong is the known empty hash, send configuration even our hash is unchanged. This provides configuration to Kong instances that have unexpectedly crashed and lost their configuration.
Add a utility function to kill a Kong container to the E2E helpers. Kill the Kong container at the end of the DB-less E2E test to ensure the controller pushes configuration after it restarts. Fix a bug in verifying Ingresses. Previously the helper continued testing on non-200 responses, and would consider the standard 404 response valid.
rainest
force-pushed
the
feat/watch-config-hash-2
branch
from
b5a68cb
to
58aca42
Compare
shaneutt
reviewed
Mar 25, 2022
rainest
changed the title
shaneutt
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bumps the Kong version to 2.8, the first version that supports this.
Resends configuration when the proxy instance reports its initial, no config present hash.
Adds tests to verify config recovers after a crash. Fixes a bug where we trusted the standard proxy 404 response when verifying Ingresses due to an improperly-bounded if.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2107Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR