Support regular expression header matches for HTTPRoute #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an HTTPRoute includes multiple header match rules with the same header name, reject the route and log the reason for rejection.
Remove support for CSVs to set multiple header match values. Although supported by Kong, the Gateway spec does not indicate this behavior, and does not allow specifying multiple values by including multiple matches for the same header name. The expected configuration to accept multiple values is a regex header match.
Add utility functions to set the Kong version once at startup and retrieve it from elsewhere without passing the version down through the call chain.
Refactor the mtls-auth version check to use the Kong version getter from the util package.
rainest
force-pushed
the
feat/regex-header
branch
from
68e4990
to
a07daab
Compare
shaneutt
reviewed
Mar 4, 2022
shaneutt
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2154Special notes for your reviewer:
KTF isn't using 2.8 yet, so the integration test here will skip the regex match and test. I ran against 2.8 locally successfully.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR