Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) update deck to v1.11.0 #2286

Merged
merged 2 commits into from
Feb 24, 2022
Merged

chore(deps) update deck to v1.11.0 #2286

merged 2 commits into from
Feb 24, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Feb 22, 2022

What this PR does / why we need it:
Updates deck, including some signature changes.

Special notes for your reviewer:
This incorporates Kong/deck#573, which means that defaults are now populated by based on what Kong reports the default as if not present. This is good, because it avoids the long-standing "unrelated change updates some value that should be 'empty' according to the requested object" problem (e.g. the removal of https_verify_certificate in the example in #2248 (comment)).

KIC has its own set of defaults embedded in the code. Many of these were previously in place only to prevent config thrashing, but some actually differ from Kong defaults, e.g.

Paths: kong.StringSlice(path),
StripPath: kong.Bool(false),
PreserveHost: kong.Bool(true),
Protocols: kong.StringSlice("http", "https"),
RegexPriority: kong.Int(0),
RequestBuffering: kong.Bool(true),
ResponseBuffering: kong.Bool(true),
includes the default buffering settings but also includes a different strip_path default.

This PR does not touch any of the defaults in KIC, as they should be benign (if unnecessary) if they match Kong's, but are essentially required if they do not, because removing them would constitute a breaking change. We may opt to try and prune these down to only the required (different) KIC defaults after.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@rainest rainest requested a review from a team as a code owner February 22, 2022 22:16
@rainest rainest temporarily deployed to Configure ci February 22, 2022 22:16 Inactive
@rainest rainest temporarily deployed to Configure ci February 22, 2022 22:21 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci February 23, 2022 14:05 Inactive
shaneutt
shaneutt previously approved these changes Feb 23, 2022
@rainest rainest temporarily deployed to Configure ci February 23, 2022 17:08 Inactive
shaneutt
shaneutt previously approved these changes Feb 23, 2022
@rainest
Copy link
Contributor Author

rainest commented Feb 23, 2022

Something broke after I originally tested the defaults change. Closed pending new version with a fix Kong/deck#596

@rainest rainest closed this Feb 23, 2022
@rainest rainest reopened this Feb 24, 2022
@rainest rainest temporarily deployed to Configure ci February 24, 2022 16:19 Inactive
@rainest rainest temporarily deployed to Configure ci February 24, 2022 16:19 Inactive
@rainest rainest temporarily deployed to Configure ci February 24, 2022 16:19 Inactive
@rainest rainest temporarily deployed to Configure ci February 24, 2022 16:19 Inactive
@github-actions
Copy link

Licenses differ between commit 96ae8ec and base:

+++ pr_licenses.csv	2022-02-24 16:21:37.249763518 +0000
@@ -1,5 +1,5 @@
 cloud.google.com/go/compute/metadata,Unknown,Apache-2.0
-cloud.google.com/go/container,Unknown,Apache-2.0
+cloud.google.com/go/container/apiv1,Unknown,Apache-2.0
 github.com/Masterminds/goutils,https://github.com/Masterminds/goutils/blob/master/LICENSE.txt,Apache-2.0
 github.com/Masterminds/semver,https://github.com/Masterminds/semver/blob/master/LICENSE.txt,MIT
 github.com/Masterminds/sprig,https://github.com/Masterminds/sprig/blob/master/LICENSE.txt,MIT```

@github-actions
Copy link

Licenses differ between commit 96ae8ec and base:

+++ pr_licenses.csv	2022-02-24 16:21:53.383070666 +0000
@@ -1,5 +1,5 @@
 cloud.google.com/go/compute/metadata,Unknown,Apache-2.0
-cloud.google.com/go/container,Unknown,Apache-2.0
+cloud.google.com/go/container/apiv1,Unknown,Apache-2.0
 github.com/Masterminds/goutils,https://github.com/Masterminds/goutils/blob/master/LICENSE.txt,Apache-2.0
 github.com/Masterminds/semver,https://github.com/Masterminds/semver/blob/master/LICENSE.txt,MIT
 github.com/Masterminds/sprig,https://github.com/Masterminds/sprig/blob/master/LICENSE.txt,MIT```

@rainest rainest temporarily deployed to Configure ci February 24, 2022 16:36 Inactive
@rainest rainest temporarily deployed to Configure ci February 24, 2022 16:36 Inactive
@rainest rainest merged commit 0f2f9be into main Feb 24, 2022
@rainest rainest deleted the chore/deck-update branch February 24, 2022 16:39
scirner22 pushed a commit to scirner22/kubernetes-ingress-controller that referenced this pull request Mar 18, 2022
* chore(deps) update deck to v1.11.0

* update mergo deps

Co-authored-by: Gabriele Gerbino <gabrielegerbino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants