-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade note for ingress.class on KCP #2093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KongClusterPlugins used to be usable without having the ingress.class explicitly set like other resources (such as Ingress) require.
seems to contradict the docs for v1.x (see the comment).
Let's clarify what the actual breaking change here is, because maybe there's none?
Pull request was closed
6478e51
to
994fa04
Compare
What this PR does / why we need it:
KongClusterPlugins used to be usable without having the
ingress.class
explicitly set like other resources (such as Ingress) require. As we've
seen some instances in the community where there's been confusion
about this, this patch retroactively adds this as a breaking change note
to the initial 2.0.x release in hopes that this will help reduce confusion
when upgrading.
Which issue this PR fixes
Fixes #2090
PR Readiness Checklist:
CHANGELOG.md
release notes have been updated