Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: upgrade note for ingress.class on KCP #2093

Closed
wants to merge 0 commits into from

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

KongClusterPlugins used to be usable without having the ingress.class
explicitly set like other resources (such as Ingress) require. As we've
seen some instances in the community where there's been confusion
about this, this patch retroactively adds this as a breaking change note
to the initial 2.0.x release in hopes that this will help reduce confusion
when upgrading.

Which issue this PR fixes

Fixes #2090

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated

@shaneutt shaneutt self-assigned this Dec 14, 2021
@shaneutt shaneutt requested a review from a team as a code owner December 14, 2021 14:18
@shaneutt shaneutt temporarily deployed to Configure ci December 14, 2021 14:18 Inactive
@shaneutt shaneutt enabled auto-merge (squash) December 14, 2021 14:21
@shaneutt shaneutt temporarily deployed to Configure ci December 14, 2021 14:32 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci December 14, 2021 15:06 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci December 14, 2021 15:18 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci December 14, 2021 15:32 Inactive
Copy link
Contributor

@mflendrich mflendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KongClusterPlugins used to be usable without having the ingress.class explicitly set like other resources (such as Ingress) require.

seems to contradict the docs for v1.x (see the comment).

Let's clarify what the actual breaking change here is, because maybe there's none?

CHANGELOG.md Outdated Show resolved Hide resolved
@shaneutt shaneutt closed this Dec 14, 2021
auto-merge was automatically disabled December 14, 2021 19:14

Pull request was closed

@shaneutt shaneutt force-pushed the shaneutt/extra-class-notes-kcp branch from 6478e51 to 994fa04 Compare December 14, 2021 19:14
@shaneutt shaneutt deleted the shaneutt/extra-class-notes-kcp branch December 14, 2021 19:14
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 19:32 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 20:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 20:34 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 21:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 21:32 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 22:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 22:34 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 23:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 14, 2021 23:33 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 00:08 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 00:46 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 01:25 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 01:49 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 03:34 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 04:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 04:39 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 05:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 05:33 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 06:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 06:37 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 07:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 07:33 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 08:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 08:36 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 09:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 09:34 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 10:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 10:35 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 11:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 11:32 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 12:04 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 12:41 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 13:07 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 13:35 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 14:03 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 14:33 Inactive
@shaneutt shaneutt temporarily deployed to gcloud December 15, 2021 15:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KongClusterPlugin can not be found
2 participants