fix: status updates for svc with > 1 ingress #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
force-pushed
the
shaneutt/fix-mult-ing-status
branch
from
a686506
to
0bba72e
Compare
1 task
This patch takes care of a problem where status updates would never complete for more than one ingress connected to a single service. It also fixes a problem where ingress resources with periods in the name (e.g. "my.ingress.resource") would fail to have their statuses updated due to a parsing error. Additionally this adds some regression tests which will prevent us reduce the possibility that these problems would be reintroduced.
shaneutt
force-pushed
the
shaneutt/fix-mult-ing-status
branch
from
0bba72e
to
8f2b326
Compare
rainest
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch takes care of a problem where status updates would
never complete for more than one ingress connected to a single
service. It also fixes a problem where ingress resources with
periods in the name (e.g. "my.ingress.resource") would fail to
have their statuses updated due to a parsing error. Additionally
this adds some regression tests which will prevent us reduce the
possibility that these problems would be reintroduced.
Which issue this PR fixes
fixes #2012
PR Readiness Checklist:
CHANGELOG.mdrelease notes have been updated