feat: add support to inject headers into Admin API calls #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Kong's control plane is protected behind Authentication or Authorization, then Kong Ingress Controller cannot talk to Kong. This change let's user specify flags to add any header(key:value) that will be added in every call to Kong's Control Plane a.k.a Admin API.
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 15.31% 15.39% +0.07%
==========================================
Files 34 35 +1
Lines 2820 2846 +26
==========================================
+ Hits 432 438 +6
- Misses 2350 2370 +20
Partials 38 38
Continue to review full report at Codecov.
|
fffonion
reviewed
Oct 19, 2018
hbagdi
added a commit
that referenced
this pull request
Oct 23, 2018
If Kong's control plane is protected behind Authentication or Authorization, then Kong Ingress Controller cannot talk to Kong. This change let's user specify flags to add any header(key:value) that will be added in every call to Kong's Control Plane a.k.a Admin API. From #172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Kong's control plane is protected behind Authentication or
Authorization, then Kong Ingress Controller cannot talk to Kong. This
change let's user specify flags to add any header(key:value) that will
be added in every call to Kong's Control Plane a.k.a Admin API.