-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] lint fixes #1599
[chore] lint fixes #1599
Conversation
#1589 introduced conflicts, whoops. Do we in fact want to include While we're here, it looks like we can strip |
I fixed in 1decdda
Anywhere there is go code, we should lint it
Sounds good 9f9cf7f |
Codecov Report
@@ Coverage Diff @@
## next #1599 +/- ##
==========================================
- Coverage 46.19% 46.15% -0.05%
==========================================
Files 71 71
Lines 6736 6745 +9
==========================================
+ Hits 3112 3113 +1
- Misses 3256 3261 +5
- Partials 368 371 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Enables lint checks on the
hack/
andinternal/
directories and cleans up all found linter issues.Also the
gci
linter is disabled because it's problematic, but a target for runninggoimports
is added which will help keep the imports consistent.Which issue this PR fixes
Fixes #1597