[chore] cleanup for v2 release #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
added
priority/medium
area/maintenance
shaneutt
force-pushed
the
v2
branch
2 times, most recently
from
35c7851
to
42979cb
Compare
shaneutt
force-pushed
the
v2
branch
3 times, most recently
from
fd2791b
to
d28e49a
Compare
The patch moves all the internals that had previously been exposed as public Golang packages into internal/ to signal that we're not supporting these for external linking. pkg/apis and pkg/clientset are our public Golang API going forward.
rainest
approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Mostly done over chat. For posterity, issues found and fixed during my review were:
- Restoring the original
deploy/directory. - Adjusting symlinks and target locations in the v2 manifest builder.
- Restored verify-tidy.sh under hack and associated lint target.
- Restored get-github-actions-logs.sh under hack.
- Added modified verify-manifests.sh (removed v1 verification) to hack and restored lint target.
Noticed but not done/deferred:
- Streamline codegen makefile targets #1358 was already open. We still don't have a v2 codegen single target or verifier.
- Container Images for 2.0 #1596 was created for this. Will re-add image jobs later.
- hack development scripts dropped. We mostly use v2 integration tests in lieu of these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: please let the author merge this PR, even if its approved and ready: I want to ensure a clean history of this change and do a rebase merge myself.
Which issue this PR fixes
Resolves #1591
Special notes for your reviewer:
There's a lot of changes, but none should ultimately be functional changes, however there are a few things of note in CI as the Github Actions worflows had to be re-worked and reconfigured to adjust for the removal of v1.x code.
Follow Ups
While making this change I realized we never made alpine/UBI images for KIC 2.0, rather than make this PR any bigger I've moved that into a follow up item: Container Images for 2.0 #1596
verify-codegen has been removed for now, and will be reworked in Streamline codegen makefile targets #1358
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR