Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] internalize controller go pkgs #1593

Closed
wants to merge 3 commits into from
Closed

[chore] internalize controller go pkgs #1593

wants to merge 3 commits into from

Conversation

shaneutt
Copy link
Contributor

What this PR does / why we need it:

We have several controller specific packages in this repository which are technically intended to be internal only, but have been technically public in our Golang API. This PR moves all the controller internals into internal/ to indicate to other Golang projects that these components are not for public use.

Which issue this PR fixes

Resolves #1591

Special notes for your reviewer:

The API types for v1 are intentionally public, but are in railgun/apis.

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@shaneutt shaneutt added priority/medium area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. labels Jul 28, 2021
@shaneutt shaneutt self-assigned this Jul 28, 2021
@shaneutt shaneutt temporarily deployed to Configure ci July 28, 2021 13:39 Inactive
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1593 (29ac172) into next (5964893) will decrease coverage by 16.75%.
The diff coverage is n/a.

❗ Current head 29ac172 differs from pull request most recent head 65fd925. Consider uploading reports for the commit 65fd925 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             next    #1593       +/-   ##
===========================================
- Coverage   51.51%   34.76%   -16.76%     
===========================================
  Files          93      123       +30     
  Lines        8758     9597      +839     
===========================================
- Hits         4512     3336     -1176     
- Misses       3934     6087     +2153     
+ Partials      312      174      -138     
Flag Coverage Δ
integration-test ?
unit-test 34.76% <ø> (-5.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/adminapi/client.go 0.00% <ø> (ø)
internal/adminapi/header_roundtripper.go 0.00% <ø> (ø)
internal/admission/server.go 43.71% <ø> (ø)
internal/admission/validator.go 90.00% <ø> (ø)
internal/annotations/annotations.go 98.01% <ø> (ø)
...ent/configuration/clientset/versioned/clientset.go 0.00% <ø> (ø)
...configuration/clientset/versioned/fake/register.go 100.00% <ø> (ø)
...nfiguration/clientset/versioned/scheme/register.go 100.00% <ø> (ø)
...ned/typed/configuration/v1/configuration_client.go 0.00% <ø> (ø)
...configuration/v1/fake/fake_configuration_client.go 0.00% <ø> (ø)
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5964893...65fd925. Read the comment docs.

@shaneutt shaneutt temporarily deployed to Configure ci July 28, 2021 13:42 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci July 28, 2021 13:43 Inactive
@shaneutt shaneutt closed this Jul 28, 2021
@shaneutt shaneutt deleted the internalize branch July 28, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/maintenance Cleanup, refactoring, and other maintenance improvements that don't change functionality. ci/license/unchanged priority/medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant