Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use AutoHandlers instead of custom enablement logic #1585

Merged
merged 14 commits into from
Aug 5, 2021

Commits on Jul 28, 2021

  1. refactor: KongClusterPlugin using AutoHandler

    also changes the signature of AutoHandler to use client.Client because client.Reader was too narrow for the refactored implementation
    mflendrich authored and shaneutt committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    d8cdf05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d9c349e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c35f20d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3871221 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2021

  1. Configuration menu
    Copy the full SHA
    b6716c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. refactor(mgr) use booleans for controller flags

    * refactor(mgr) use booleans for controller flags
    
    Change flags for managing controllers from a custom
    enabled/auto/disabled type to booleans. By default, all controllers are
    enabled. If a controller's enable flag is set to false, it is disabled.
    Enabled controllers that have an auto loader are loaded if they are
    enabled and their auto loader indicates they should load.
    
    Remove the KongStateEnabled flag. This was a leftover from an earlier
    design where the controller managed Kong state information via a special
    Secret. It had no remaining associated code and was only present in
    configuration.
    
    Rename controller flags to reflect that they enable controllers.
    
    Remove enablement status type, associated utility functions, and custom
    flag handler.
    
    * fix(test) only defer body close if exists
    
    Move deferred body close checks after the error checkers. If an error is
    present, no body exists, and the deferred attempt to close it segfaults.
    
    Co-authored-by: Michał Flendrich <michal@flendrich.pro>
    Travis Raines and mflendrich committed Aug 3, 2021
    Configuration menu
    Copy the full SHA
    7448c15 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Configuration menu
    Copy the full SHA
    3ebf32f View commit details
    Browse the repository at this point in the history
  2. fix: ineffassign

    mflendrich committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    4420e00 View commit details
    Browse the repository at this point in the history
  3. fix: unused param

    mflendrich committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    5765b44 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2fc9fd2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    08a6e22 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ed08d60 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e2c9dd8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b5f3145 View commit details
    Browse the repository at this point in the history