Fix Ingress v1beta1 API resource group #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2021 11:04
Change the API group for the original v1beta1 Ingress from apiextensions.k8s.io to extensions. See https://v1-17.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.17/#ingress-v1beta1-extensions for reference. apiextensions.k8s.io is for CRDs instead.
Codecov Report
@@ Coverage Diff @@
## next #1584 +/- ##
==========================================
+ Coverage 51.42% 51.55% +0.12%
==========================================
Files 93 93
Lines 8758 8758
==========================================
+ Hits 4504 4515 +11
+ Misses 3940 3932 -8
+ Partials 314 311 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mflendrich
approved these changes
Jul 23, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changes the API group (URL) for the original v1beta1 Ingress from
apiextensions.k8s.iotoextensions.Which issue this PR fixes:
AFAICT this was just wrong originally, and was never caught because integration tests only try against one Ingress version (V1). apiextensions contains the CRD definition, not Ingress. Caught while reviewing permissions differences between v1 and v2.
Notes
First commit is the actual change. Most of the diff is from running generators afer.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR