Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KIC 2.0][feature] Add knative Ingress #1396

Merged
merged 53 commits into from
Jun 22, 2021
Merged

[KIC 2.0][feature] Add knative Ingress #1396

merged 53 commits into from
Jun 22, 2021

Conversation

ccfishk
Copy link
Contributor

@ccfishk ccfishk commented Jun 4, 2021

What this PR does / why we need it:
what:
Using KIC 2.0 with Knative

Why:
Knative is supported in KIC 1.3.0. Need migrate it to KIC 2.0

Checklist
Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR
  • Continuation Test including dbless, postgress and legacy all pass.

@ccfishk ccfishk requested a review from a team as a code owner June 4, 2021 14:18
@CLAassistant
Copy link

CLAassistant commented Jun 4, 2021

CLA assistant check
All committers have signed the CLA.

@ccfishk ccfishk changed the title Issue 1148 WIP Issue 1148 Jun 4, 2021
@ccfishk ccfishk changed the title WIP Issue 1148 [WIP] Issue 1148 - Add knative API support in KIC 2.0 Jun 4, 2021
@shaneutt shaneutt added the wip label Jun 4, 2021
@ccfishk ccfishk changed the title [WIP] Issue 1148 - Add knative API support in KIC 2.0 [WIP] KIC 2.0 Issue 1148 - Add knative API support in KIC 2.0 Jun 4, 2021
@ccfishk ccfishk changed the title [WIP] KIC 2.0 Issue 1148 - Add knative API support in KIC 2.0 [WIP] KIC 2.0 Issue 1148 - Add knative API support Jun 4, 2021
@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #1396 (7c3edf1) into next (3600658) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1396      +/-   ##
==========================================
+ Coverage   55.76%   55.87%   +0.10%     
==========================================
  Files          43       43              
  Lines        3683     3685       +2     
==========================================
+ Hits         2054     2059       +5     
+ Misses       1480     1478       -2     
+ Partials      149      148       -1     
Impacted Files Coverage Δ
pkg/annotations/annotations.go 90.62% <ø> (ø)
pkg/store/store.go 32.11% <100.00%> (+0.41%) ⬆️
pkg/parser/parser.go 84.12% <0.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3600658...7c3edf1. Read the comment docs.

@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 01:17 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 01:17 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 01:18 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 01:18 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 01:19 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 06:16 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 19, 2021 06:16 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 20, 2021 00:56 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 20, 2021 00:56 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 22, 2021 09:32 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 22, 2021 09:32 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 22, 2021 09:44 Inactive
@ccfishk ccfishk temporarily deployed to Configure ci June 22, 2021 09:44 Inactive
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments: I think we're going to need to pull back on the background controller loader for knative.

railgun/manager/run.go Show resolved Hide resolved
railgun/manager/run.go Show resolved Hide resolved
@ccfishk ccfishk requested a review from shaneutt June 22, 2021 16:37
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple follow up items, but otherwise let's get the value we have here merged in! 👍

@ccfishk ccfishk merged commit efe9360 into next Jun 22, 2021
@ccfishk ccfishk deleted the issue-1148 branch June 22, 2021 16:43
@rainest rainest mentioned this pull request Jun 24, 2021
1 task
@ccfishk ccfishk changed the title [KIC 2.0] Add knative Ingress support [KIC 2.0][feature] Add knative Ingress Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants