-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KIC 2.0][feature] Add knative Ingress #1396
Conversation
Codecov Report
@@ Coverage Diff @@
## next #1396 +/- ##
==========================================
+ Coverage 55.76% 55.87% +0.10%
==========================================
Files 43 43
Lines 3683 3685 +2
==========================================
+ Hits 2054 2059 +5
+ Misses 1480 1478 -2
+ Partials 149 148 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small comments: I think we're going to need to pull back on the background controller loader for knative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple follow up items, but otherwise let's get the value we have here merged in! 👍
What this PR does / why we need it:
what:
Using KIC 2.0 with Knative
Why:
Knative is supported in KIC 1.3.0. Need migrate it to KIC 2.0
Checklist
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR