fix: rename name to plugin in KongPlugin resource #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for the issue introduced in 32ca70f. `name` is already a property defined for every resource in k8s, which is unique across all objects of the same kind. The `name` from metav1.objectMeta needs to be accessible in other parts of code to correctly read the object. This commit renames the `name` to `plugin` field.
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 31.39% 31.39%
=======================================
Files 33 33
Lines 2956 2956
=======================================
Hits 928 928
Misses 1915 1915
Partials 113 113
Continue to review full report at Codecov.
|
fffonion
approved these changes
Sep 10, 2018
hbagdi
added a commit
that referenced
this pull request
Oct 23, 2018
This is a fix for the issue introduced in 32ca70f. `name` is already a property defined for every resource in k8s, which is unique across all objects of the same kind. The `name` from metav1.objectMeta needs to be accessible in other parts of code to correctly read the object. This commit renames the `name` to `plugin` field. From #122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue introduced in 32ca70f.
nameis already a property defined for every resource in k8s, which isunique across all objects of the same kind.
The
namefrom metav1.objectMeta needs to be accessible in other partsof code to correctly read the object.
This commit renames the
nametopluginfield.